From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 13 Sep 2023 00:32:48 GMT
Subject: Re: [PATCH v2] sequencer: remove unreachable exit condition in pick_commits()
Message-ID: <xmqqwmwukj4f.fsf@gitster.g>
In-Reply-To: <7ede7c26-9029-4e4b-81a3-f992eff74124@gmail.com>

Phillip Wood <phillip.wood123@gmail.com> writes:

> On 12/09/2023 11:55, Oswald Buddenhagen wrote:
>> This was introduced by 56dc3ab04 ("sequencer (rebase -i): implement the
>> 'edit' command", 2017-01-02), and was pointless from the get-go: all
>> early exits from the loop above are returns, so todo_list->current ==
>> todo_list->nr is an invariant after the loop.
>> Signed-off-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
>
> Thanks for updating the commit message, I think it is clearer now

Thanks, both.  Queued.