From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 21 Sep 2023 21:18:49 GMT
Subject: Re: [PATCH] test-lib: set UBSAN_OPTIONS to match ASan
Message-ID: <xmqqwmwj443q.fsf@gitster.g>
In-Reply-To: <20230921041825.GA2814583@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

> So that's garbage memory which would _usually_ cause us to segfault, but
> UBSan catches it and complains first about the alignment. That makes
> sense, but the weird thing is that UBSan then exits instead of aborting,
> so our test_might_fail call considers that an acceptable outcome and the
> test "passes".

t4058 unexpectedly succeeding vaguely rings a bell to me, too, but
it has been sporadic.  The changes are obviously the right thing to
do.

Thanks, queued.