From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 06 Feb 2024 18:44:21 GMT
Subject: Re: [PATCH] commit.c: ensure strchrnul() doesn't scan beyond range
Message-ID: <xmqqwmrhh1q2.fsf@gitster.g>
In-Reply-To: <ce83bd09-dbd2-4c9e-8197-6e4800935523@web.de>

René Scharfe <l.s.r@web.de> writes:

>>  	while (line && line < msg + len) {
>>  		const char *eol = strchrnul(line, '\n');
>> +		assert(eol - line <= len);
>
> Something like this might work in Verse, but C is more simple-minded.
> You can't undo an out-of-bounds access after the fact, and assert()
> would be compiled out if the code is built with NDEBUG anyway.

Good comments.  Thanks.