From: Junio C Hamano Date: Wed, 07 Feb 2024 16:58:25 GMT Subject: Re: [PATCH v2 5/5] cache-tree: avoid an unnecessary check Message-ID: In-Reply-To: <43c04749513d07733f5fa2c15a694d99d31fe6e3.1707324462.git.gitgitgadget@gmail.com> "Johannes Schindelin via GitGitGadget" writes: > From: Johannes Schindelin > > The first thing the `parse_tree()` function does is to return early if > the tree has already been parsed. Therefore we do not need to guard the > `parse_tree()` call behind a check of that flag. Makes sense, and it doubly makes sense to keep this separate from the change done to the same location in [4/5]. Will queue.