From: Junio C Hamano Date: Wed, 17 Apr 2024 16:53:58 GMT Subject: Re: [PATCH 0/2] builtin/receive-pack: convert to use git-maintenance(1) Message-ID: In-Reply-To: Karthik Nayak writes: >> this small patch series adapts git-receive-pack(1) to spawn `git >> maintenance run --auto` instead of `git gc --auto` like all the other >> parts of our codebase do nowadays. This removes the last internal user >> of `git gc --auto`. > > I don't have enough context here, so why do this? I think the intent of a95ce124 (maintenance: replace run_auto_gc(), 2020-09-17) was to update all codepaths that run "git gc --auto" to instead run "git maintenance --auto", but only updated the ones that used to call run_auto_gc(). The codepath Patrick found runs "git gc --auto" without using run_auto_gc() and was left behind when the others were converted. So why do this? I think "To follow through a95ce124 started" would probably be a good enough reason, if a reader is on board with what a95ce124 wanted to do. Do we have a handy reference that compares "gc --auto" and "maintenance --auto"? Are they essentially the same thing these days? What are the things that is done by one but not by the other? THanks.