From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 22 Apr 2024 15:50:01 GMT
Subject: Re: [PATCH 2/4] add-interactive: plug a leak in get_untracked_files
Message-ID: <xmqqwmopxuqe.fsf@gitster.g>
In-Reply-To: <88b119aa-c1c2-435a-baaa-9422388bf0ec@gmail.com>

Rubén Justo <rjusto@gmail.com> writes:

> Plug a leak we have since ab1e1cccaf (built-in add -i: re-implement
> `add-untracked` in C, 2019-11-29).
>
> This leak can be triggered with:
>
> 	$ echo a | git add -i
>
> As a curiosity, we have a somewhat similar function in builtin/stash.c,
> which correctly frees the memory.

Yup, 

    $ git grep -W -e fill_directory -e dir_clear -e setup_standard_excludes \*.c

makes an interesting read ;-)

The fix looks good.  Thanks.

> Signed-off-by: Rubén Justo <rjusto@gmail.com>
> ---
>  add-interactive.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/add-interactive.c b/add-interactive.c
> index 6bf87e7ae7..e17602b5e4 100644
> --- a/add-interactive.c
> +++ b/add-interactive.c
> @@ -865,6 +865,7 @@ static int get_untracked_files(struct repository *r,
>  	}
>  
>  	strbuf_release(&buf);
> +	dir_clear(&dir);
>  	return 0;
>  }