From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 02 Sep 2025 22:25:24 GMT
Subject: Re: [PATCH v2 1/5] fsck: order 'fsck_msg_type' alphabetically
Message-ID: <xmqqwm6gh4q3.fsf@gitster.g>
In-Reply-To: <20250902-228-reftable-introduce-consistency-checks-v2-1-4f96b3834779@gmail.com>

Karthik Nayak <karthik.188@gmail.com> writes:

> The list of 'fsck_msg_type' seem to be alphabetically ordered, but there
> are a few small misses. Fix this by sorting the sub-sections of the
> list to maintain alphabetical ordering. Also fix a clang-format issue
> where the escaped newlines are not aligned.
>
> While here, remove a duplicate instance of 'gitmodulesLarge' in the
> 'fsck-msgids' documentation.

"A few small misses".

> diff --git a/fsck.h b/fsck.h
> index dd7df3d5b3..559ad57807 100644
> --- a/fsck.h
> +++ b/fsck.h
> @@ -20,82 +20,82 @@ enum fsck_msg_type {
> ...
> -#define FOREACH_FSCK_MSG_ID(FUNC) \
> -	/* fatal errors */ \
> -	FUNC(NUL_IN_HEADER, FATAL) \
> -	FUNC(UNTERMINATED_HEADER, FATAL) \
> ...
> +#define FOREACH_FSCK_MSG_ID(FUNC)                                  \
> +	/* fatal errors */                                         \
> +	FUNC(NUL_IN_HEADER, FATAL)                                 \
> +	FUNC(UNTERMINATED_HEADER, FATAL)                           \
> ...

Please undo these "pad by spaces before backslash"; otherwise we
cannot tell which ones are "a few small misses".

Thanks.