From: Junio C Hamano Date: Tue, 02 Dec 2025 02:05:07 GMT Subject: Re: [PATCH v2 0/5] Audit and document Scalar config Message-ID: In-Reply-To: "Derrick Stolee via GitGitGadget" writes: > -@@ scalar.c: static int set_scalar_config(const struct scalar_config *config, int reconfigure > +@@ scalar.c: struct scalar_config { > + int overwrite_on_reconfigure; > + }; > + > ++static int set_config_with_comment(const char *key, const char *value) I do not care too deeply as this is a file-scope static that is called only twice, but I would have preferred scalar_set_config() which is a lot more specificto the purpose of this function (and the comment "# set by scalar" is hardcoded constant in this function that its callers cannot affect, so "with_comment" is not even a statement that "the callers can add comment to their config settings") which would have taken a bit shorter line to call. > +fetch.unpackLimit=1:: > + This setting prevents Git from unpacking packfiles into loose objects > -+ as they are downloaded from the server. This feature was intended as a > -+ way to prevent performance issues from too many packfiles, but Scalar > -+ uses background maintenance to group packfiles and cover them with a > -+ multi-pack-index, removing this issue. > ++ as they are downloaded from the server. The default limit of 100 was > ++ intended as a way to prevent performance issues from too many packfiles, > ++ but Scalar uses background maintenance to group packfiles and cover them > ++ with a multi-pack-index, removing this issue. Nicely explained. Will replace (when I land). Thanks.