From: Junio C Hamano Date: Mon, 22 Jun 2026 16:26:29 GMT Subject: Re: [PATCH v3 0/4] pack-objects: support bitmaps and delta-islands with `--path-walk` Message-ID: In-Reply-To: Derrick Stolee writes: > On 6/22/2026 3:35 AM, Junio C Hamano wrote: >> Taylor Blau writes: > >>> Outside of the above, the series is functionally unchanged. >>> >>> Thanks in advance for another look. >>> >>> Taylor Blau (4): >>> t/perf: drop p5311's lookup-table permutation >>> pack-objects: support reachability bitmaps with `--path-walk` >>> pack-objects: extract `record_tree_depth()` helper >>> pack-objects: support `--delta-islands` with `--path-walk` >> >> Very cleanly implemented. I am not confident that I have followed >> the detailed logic around delta islands in the last step but the >> earlier three patches looked trivially good. > I've been happy with the code, subject to the new data that is presented > with this version confirming the expected performance benefits. I also > lack confidence in the delta islands features, but based on my weak > understanding it looks correct. I believe that Taylor has the right > expertise here to make up for my lack of context. Thanks. Let me mark the topic for 'next' then.