From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 23 Sep 2026 17:17:05 GMT
Subject: Re: [PATCH] ci: work around Debian 12's HTTP/2 authentication failures
Message-ID: <xmqqwlsbc2ge.fsf@gitster.g>
In-Reply-To: <20260923165922.GB29229@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

> +# Curl 7.88.1 can fail to retry authentication after an early HTTP/2
> +# response. This was fixed in curl 8.3.0; see
> +# https://github.com/curl/curl/pull/11756. The first affected version is
> +# unknown, so conservatively assume that versions from 7.88.1 up to (but
> +# not including) 8.3.0 are broken.

Just nitpicking the wording, but if the first affected version is
truly unknown, assuming that versions from 7.88.1 up is *not* a
conservative thing to do at all, is it?

If 7.88.1 is from an irrelevantly ancient past, I would say that we
should just skip anything older than 8.3.0, but 7.88.1 is from early
2023 and we cannot do such a simplification.

> +test_lazy_prereq HAVE_CURL_HTTP2_BUG '
> +	test_have_prereq HTTP2 &&
> +	build_option libcurl |
> +	awk -F. '\''
> +		($1 == 7 && ($2 > 88 || ($2 == 88 && $3 >= 1))) ||
> +		($1 == 8 && $2 < 3) { broken = 1 }
> +		END { exit !broken }
> +	'\''
> +'
> +
>  test_expect_success HTTP2 'enable client-side http/2' '
>  	git config --global http.version HTTP/2
>  '
>
> which is not _too_ ugly.
>
> -Peff