From: Junio C Hamano Date: Sat, 07 Nov 2026 23:15:09 GMT Subject: Re: [PATCH 1/3] t/helper: rename test-genzeros.c to test-genbytes.c Message-ID: In-Reply-To: "Kristofer Karlsson via GitGitGadget" writes: > From: Kristofer Karlsson > > The next commit adds a "genbytes" command to this file and turns > "genzeros" into a thin wrapper around it. Rename the file in a > separate step first, so that git can detect the rename and the actual > changes show up as a regular diff, which is easier to review. > > No functional changes. > > Signed-off-by: Kristofer Karlsson > --- > Makefile | 2 +- > t/helper/meson.build | 2 +- > t/helper/{test-genzeros.c => test-genbytes.c} | 0 > 3 files changed, 2 insertions(+), 2 deletions(-) > rename t/helper/{test-genzeros.c => test-genbytes.c} (100%) Needless to say, with this patch applied, the following tests would now fail, unable to find "test-tool genzeros". t0613-reftable-write-options.sh t1007-hash-object.sh t1051-large-conversion.sh t1450-fsck.sh t4141-apply-too-large.sh t4205-log-pretty-formats.sh t5300-pack-object.sh t5318-commit-graph.sh t7006-pager.sh t9850-shell.sh FWIW, if you apply [1/3] and [2/3], squash them together, then give a custom rename factor to the command, e.g., $ git format-patch -M3 -1 to format the resulting single patch, you will see a modification of genzeros while the file gets renamed just fine, and you would not have to break these tests in the middle of a series.