From: Junio C Hamano Date: Fri, 28 Mar 2014 17:20:19 GMT Subject: Re: [PATCH 1/3] test-lib: Document short options in t/README Message-ID: In-Reply-To: Junio C Hamano writes: > Ilya Bobyr writes: > >> If there is decision on how shortening should work for all the >> options, maybe I could add a paragraph on that and make existing >> options more consistent. > > We should strive to make the following from gitcli.txt apply > throughout the system: > > * many commands allow a long option `--option` to be abbreviated > only to their unique prefix (e.g. if there is no other option > whose name begins with `opt`, you may be able to spell `--opt` to > invoke the `--option` flag), but you should fully spell them out > when writing your scripts; later versions of Git may introduce a > new option whose name shares the same prefix, e.g. `--optimize`, > to make a short prefix that used to be unique no longer unique. > >> If so, '--valgrind' becomes impossible to shorten because there >> is '--valgrind-only' that is a separate option. Same for >> '--verbose' and '--verbose-only'. > > Correct. If you really cared, --valgrind={yes,no,only} would be (or > have been) a better possibility, though. Also, these existing bits are simply being lazy. You do not have to emulate and spread the laziness. t/test-lib.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/t/test-lib.sh b/t/test-lib.sh index 87f327f..f37973a 100644 --- a/t/test-lib.sh +++ b/t/test-lib.sh @@ -209,10 +209,10 @@ do --va|--val|--valg|--valgr|--valgri|--valgrin|--valgrind) valgrind=memcheck shift ;; - --valgrind=*) + --va=*|--val=*|--valg=*|--valgr=*|--valgri=*|--valgrin=*|--valgrind=*) valgrind=$(expr "z$1" : 'z[^=]*=\(.*\)') shift ;; - --valgrind-only=*) + --valgrind-o=*|--valgrind-on=*|--valgrind-onl=*|--valgrind-only=*) valgrind_only=$(expr "z$1" : 'z[^=]*=\(.*\)') shift ;; --tee)