From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 12 Aug 2014 21:38:45 GMT
Subject: Re: [PATCH] mailsplit.c: remove dead code
Message-ID: <xmqqvbpx4cd6.fsf@gitster.dls.corp.google.com>
In-Reply-To: <vpqy4utz8x5.fsf@anie.imag.fr>

Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:

> Stefan Beller <stefanbeller@gmail.com> writes:
>
>> +	if (is_bare && !allow_bare) {
>> +		unlink(name);
>> +		fprintf(stderr, "corrupt mailbox\n");
>> +		exit(1);
>> +	}
>
> Not directly related to your patch, but shouldn't this be using
>
> die(_("corrupt mailbox"));
>
> instead?

Doesn't the exit status of mailsplit matter to its existing
invokers?