From: Junio C Hamano Date: Wed, 21 Jan 2015 18:51:02 GMT Subject: Re: [PATCH 20/24] update-index: test the system before enabling untracked cache Message-ID: In-Reply-To: Duy Nguyen writes: > On Wed, Jan 21, 2015 at 3:32 PM, Junio C Hamano wrote: >> Nguyễn Thái Ngọc Duy writes: >> >>> Helped-by: Eric Sunshine >>> Signed-off-by: Nguyễn Thái Ngọc Duy >>> Signed-off-by: Junio C Hamano >>> --- >> >> It appears that this hijacks a fixed name dir-mtime-test at the root >> level of every project managed by Git. Is that intended? > > I did think about filename clash, but I chose a fixed name anyway for > simplicity, otherwise we would need to reconstruct paths > "dir-mtime-test/..." in many places. If you stuff the name of test directory (default "dir-mtime-test") in a strbuf and formulate test paths by chomping to the original and then appending "/..." at the end, like your remove_test_directory() already does, wouldn't that be sufficient? >> Shouldn't --use-untracked-cache option require the working tree >> (i.e. die in a bare repository)? > > setup_work_tree() takes care of that OK, thanks.