From: Junio C Hamano <gitster@pobox.com>
Date: Sun, 12 Jul 2015 17:32:22 GMT
Subject: Re: [PATCH v5 00/44] Make git-am a builtin
Message-ID: <xmqqvbdpi8nt.fsf@gitster.dls.corp.google.com>
In-Reply-To: <CACRoPnQyPpK3g0G3N-Yf2Zatk5RCEUe_1mbW9LGq8-=zypYcNg@mail.gmail.com>

Paul Tan <pyokagan@gmail.com> writes:

>> However, I am reluctant to blindly replace assert(!state->field)
>> with free(state->field).  Are there cases where we _must_ call a
>> function that sets these fields at most once?
>
> I wouldn't say we are "blindly" replacing them.

I said "I was", not "you and me".  If there was a case where we
should never call into a codepath once these fields are already
initialized, then we need to keep assert(!state->field) in such a
codepath.  I didn't know if that were the case, hence I would have
been blindly replacing, which I didn't want to do.  And that is why
I asked _you_ ;-)