From: Junio C Hamano Date: Mon, 15 Aug 2016 22:38:07 GMT Subject: Re: [PATCH 2/2] checkout: do not mention detach advice for explicit --detach option Message-ID: In-Reply-To: <20160815211354.vsyg3lpira6pttom@sigill.intra.peff.net> Jeff King writes: >> REF_NODEREF, UPDATE_REFS_DIE_ON_ERR); >> if (!opts->quiet) { >> if (old->path && >> - (advice_detached_head == 1 || >> - (advice_detached_head == -1 && !opts->force_detach))) >> + advice_detached_head == 1 && !opts->force_detach) > > Maybe s/== 1//? Surely, and thanks.