From: Junio C Hamano Date: Fri, 15 Feb 2019 22:38:15 GMT Subject: Re: [PATCH v2 06/19] checkout: move 'confict_style' and 'dwim_..' to checkout_opts Message-ID: In-Reply-To: <20190208090401.14793-7-pclouds@gmail.com> Nguyễn Thái Ngọc Duy writes: > These local variables are referenced by struct option[]. This struct > will soon be broken down, moved away and we can't rely on local > variables anymore. Move these two to struct checkout_opts in > preparation for that. > > Signed-off-by: Nguyễn Thái Ngọc Duy > --- Up to this point all patches made sense to me. Thanks for working on this.