From: Junio C Hamano Date: Tue, 07 Jan 2020 17:01:14 GMT Subject: Re: [PATCH 0/1] Update imap-send.c, fix incompatibilities with OpenSSL 1.1.x Message-ID: In-Reply-To: Johannes Schindelin writes: > Hi Liam, > > On Tue, 7 Jan 2020, Liam Huang via GitGitGadget wrote: > >> Some APIs have been changed since OpenSSL 1.1.0, so fix incompatibilities >> with OpenSSL 1.1.x. > > In your PR, the "Checks" tab shows that this breaks the build for all > non-32-bit Linux builds and for Windows. Here is an excerpt of the failed > `linux-clang` build: > -- snip -- > ... > Could you fix those compile errors, please? > > While at it, please also fix your author email: it should match your > _real_ email address, i.e. "liamhuang0205@gmail.com", not > "Liam0205@users.noreply.github.com". Also, please do *not* CC iterations of a patch to me that hasn't seen a concensus that it is a good idea on the list yet, unless you know I am the area expert and am interested in seeing it. Thanks.