From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 16 Jan 2023 16:26:21 GMT
Subject: Re: [PATCH 3/3] http: support CURLOPT_PROTOCOLS_STR
Message-ID: <xmqqv8l6cuoi.fsf@gitster.g>
In-Reply-To: <xmqqzgaicvmj.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

>> +#if GIT_CURL_HAVE_CURLOPT_PROTOCOLS_STR
>> +#define GIT_CURLOPT_REDIR_PROTOCOLS_STR CURLOPT_REDIR_PROTOCOLS_STR 
>> +#define GIT_CURLOPT_PROTOCOLS_STR CURLOPT_PROTOCOLS_STR
>> +#else
>> +#define GIT_CURLOPT_REDIR_PROTOCOLS_STR 0
>> +#define GIT_CURLOPT_PROTOCOLS_STR 0
>>  #endif
>
> I find it a bit ugly that CURLOPT_* being used are all non-zero, but
> it may be true in practice.

Sorry for making the first half of the sentence unintelligible.  I
meant to say that it is ugly that the correctness of the solution
depends on the real value for these macros being non-zero.