From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 24 Apr 2024 19:07:32 GMT
Subject: Re: [PATCH v3] fuzz: link fuzz programs with `make all` on Linux
Message-ID: <xmqqv846y3yj.fsf@gitster.g>
In-Reply-To: <ba9d24c6445de309226bf7c165499f1969807fef.1713982389.git.steadmon@google.com>

Josh Steadmon <steadmon@google.com> writes:

> Since linking the fuzzer executables without a fuzzing engine does not
> require a C++ compiler, we can change the FUZZ_PROGRAMS build rule to
> use $(CC) by default. This avoids compiler mis-match issues when
> overriding $(CC) but not $(CXX). When we *do* want to actually link with
> a fuzzing engine, we can set $(FUZZ_CXX). The build instructions in the
> CI fuzz-smoke-test job and in the Makefile comment have been updated
> accordingly.
>
> While we're at it, we can consolidate some of the fuzzer build
> instructions into one location in the Makefile.

Looks good to me.  Will replace and let's mark it for 'next'.

I do not recall suggesting anything concrete on this one, though ;-)

Thanks.

> Suggested-by: Junio C Hamano <gitster@pobox.com>
> Helped-by: Jeff King <peff@peff.net>
> Signed-off-by: Josh Steadmon <steadmon@google.com>
> ---
> Changes in V3:
> * Dropped CI config patch; no longer needed since we don't use CXX in
>   fuzzer build rules anymore