From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 04 Mar 2025 18:05:15 GMT
Subject: Re: [PATCH v3 1/1] t1403: verify that path exists and is a file
Message-ID: <xmqqv7sopt7o.fsf@gitster.g>
In-Reply-To: <20250304094153.28959-2-danimahendra0904@gmail.com>

Mahendra Dani <danimahendra0904@gmail.com> writes:

> test -e does not provide a nice error message when
> we hit test failures, so use test_path_exists() instead
> and verify that if the path exists then it is a file using test_path_is_file().
>
> Signed-off-by: Mahendra Dani <danimahendra0904@gmail.com>
> ---
>  t/t1403-show-ref.sh | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/t/t1403-show-ref.sh b/t/t1403-show-ref.sh
> index 9d698b3cc3..4afde01a29 100755
> --- a/t/t1403-show-ref.sh
> +++ b/t/t1403-show-ref.sh
> @@ -196,7 +196,8 @@ test_expect_success 'show-ref --verify with dangling ref' '
>  
>  	remove_object() {
>  		file=$(sha1_file "$*") &&
> -		test -e "$file" &&
> +		test_path_exists "$file" &&
> +		test_path_is_file "$file" &&
>  		rm -f "$file"
>  	} &&

Makes sense.  Will queue.