From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 06 May 2025 19:16:07 GMT
Subject: Re: [PATCH 2/4] packed-backend: extract snapshot allocation in `load_contents`
Message-ID: <xmqqv7qdim88.fsf@gitster.g>
In-Reply-To: <aBo7pcimOG19oInQ@ArchLinux>

shejialuo <shejialuo@gmail.com> writes:

> "load_contents" would choose which way to load the content of the
> "packed-refs". However, we cannot directly use this function when
> checking the consistency due to we don't want to open the file. And we
> also need to reuse the logic to avoid causing repetition.
>
> Let's create a new helper function "allocate_snapshot_buffer" to extract
> the snapshot allocation logic in "load_contents" and update the
> "load_contents" to align with the behavior.
>
> Suggested-by: Jeff King <peff@peff.net>
> Suggested-by: Patrick Steinhardt <ps@pks.im>
> Signed-off-by: shejialuo <shejialuo@gmail.com>
> ---
>  refs/packed-backend.c | 54 +++++++++++++++++++++++++------------------
>  1 file changed, 32 insertions(+), 22 deletions(-)

Trivially correct, cleanly done, and nicely described.

Thanks.