From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 12 Jan 2026 20:46:05 GMT
Subject: Re: [PATCH v23 2/2] status: show comparison with push remote tracking branch
Message-ID: <xmqqv7h6lfua.fsf@gitster.g>
In-Reply-To: <f1ad7a1b6f7239c5f52a9a74721f340cb35d0b36.1768249586.git.gitgitgadget@gmail.com>

"Harald Nordgren via GitGitGadget" <gitgitgadget@gmail.com> writes:

> +	bool want_push_advice = (flags & BRANCH_MODE_PUSH) &&
> +		advice_enabled(ADVICE_STATUS_HINTS);
> +	bool want_pull_advice = (flags & BRANCH_MODE_PULL) &&
> +		advice_enabled(ADVICE_STATUS_HINTS);
> +	bool want_divergence_advice = show_divergence_advice &&
> +		advice_enabled(ADVICE_STATUS_HINTS);

Just an observation, and not an objection, but it looks curious why
the last one is so different from the other two.  IOW, the above
makes me wonder if it makes sense to roll the show_divergence_advice
bit into the base_branch_modes flag word.

Other than that, this round is a pleasant read.  Thanks.