From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 23 May 2014 21:56:26 GMT
Subject: Re: [PATCH v2] Get rid of the non portable shell export VAR=VALUE costruct
Message-ID: <xmqqtx8ggnw5.fsf@gitster.dls.corp.google.com>
In-Reply-To: <20140523184405.GE12314@google.com>

Jonathan Nieder <jrnieder@gmail.com> writes:

> -	/^\s*export\s+[^=]*=/ and err '"export FOO=bar" is not por...
> +	/\bexport\s+[A-Za-z0-9_]*=/ and err '"export FOO=bar" is n...

I see you also tightened what the "variable" to be assigned should
look like, which is a good change to avoid false positives.

Because the inter-word dash is taken as a word "\b"oundary, that
change incidentally prevents a false positive from triggering on
something like:

	git fast-export --option=value

;-)