From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 10 Jun 2014 15:36:30 GMT
Subject: Re: [PATCH] git-submodule.sh: avoid "test <cond> -a/-o <cond>"
Message-ID: <xmqqtx7sai9t.fsf@gitster.dls.corp.google.com>
In-Reply-To: <53972229.5040104@viscovery.net>

Johannes Sixt <j.sixt@viscovery.net> writes:

> Am 6/10/2014 16:55, schrieb Junio C Hamano:
>> Elia Pinto <gitter.spiros@gmail.com> writes:
>> 
>>> @@ -832,7 +832,7 @@ Maybe you want to use 'update --init'?")"
>>>  			continue
>>>  		fi
>>>  
>>> -		if ! test -d "$sm_path"/.git -o -f "$sm_path"/.git
>>> +		if ! test -d "$sm_path"/.git || test -f "$sm_path"/.git
>> 
>> Which part of test conditions does that "!" apply in the original,
>> and in the updated? 
>> 
>> I think the new test after || also needs negation, no?
>
> Not just that; the || must be turned into && as well.

I think our mails crossed ;-)