From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 02 Apr 2015 20:59:48 GMT
Subject: Re: [PATCH 3/4] diff --cc: relax too strict paths picking
Message-ID: <xmqqtwwyi6uz.fsf@gitster.dls.corp.google.com>
In-Reply-To: <1428006853-21212-4-git-send-email-max@max630.net>

Max Kirillov <max@max630.net> writes:

Again, just surface nitpicks.

[side: Kirill Smelkov <kirr@mns.spb.ru> removed from CC, as the
ddress just bounced for me]

> +static int changed_parents(struct combine_diff_path *p, int n)
> +{
> +	int parent_idx;
> +	int result = 0;
> +
> +	for (parent_idx = 0; parent_idx < n; ++parent_idx) {
> +		if (p->parent[parent_idx].status != ' ')
> +			++result;

We write C (not C++) and favor post_increment++ over ++pre_increment
when there is no valid reason to do otherwise (e.g. the result of
increment getting used in a larger expression).

Thanks.