From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 10 May 2016 21:11:02 GMT
Subject: Re: [PATCH 5/6] t1500: avoid setting environment variables outside of tests
Message-ID: <xmqqtwi5mxeh.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20160510230111.Horde.JpLRouwWbSCYp7yuvqhy5SS@webmail.informatik.kit.edu>

SZEDER Gábor <szeder@ira.uka.de> writes:

> I wonder if is it really necessary to specify the path to the .git
> directory via $GIT_DIR.  Would 'git --git-dir=/over/there' be just as
> good?

Then you are testing two different things that may go through
different codepaths.

Adding yet another test to check "git --git-dir=" in addition is
fine, but that is not a replacement.  We do want to make sure that
"GIT_DIR=there git" form keeps giving us the expected outcome.