From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 16 Jan 2017 07:48:55 GMT
Subject: Re: What's cooking in git.git (Jan 2017, #02; Sun, 15)
Message-ID: <xmqqtw8za1i0.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <257b4175-9879-7814-5d8d-02050792574d@kdbg.org>

Johannes Sixt <j6t@kdbg.org> writes:

> Am 16.01.2017 um 02:51 schrieb Junio C Hamano:
>> * jk/vreport-sanitize (2017-01-11) 2 commits
>>  - vreport: sanitize ASCII control chars
>>  - Revert "vreportf: avoid intermediate buffer"
>>
>>  An error message with an ASCII control character like '\r' in it
>>  can alter the message to hide its early part, which is problematic
>>  when a remote side gives such an error message that the local side
>>  will relay with a "remote: " prefix.
>>
>>  Will merge to 'next'.
>
> Please be not too hasty with advancing this topic to master. I could
> imagine that there is some unwanted fallout on systems where the
> end-of-line marker CRLF is common. Though, I haven't tested the topic
> myself, yet, nor do I expect regressions in *my* typical workflow.

Thanks; will wait for a further discussion on the topic's thread
then.