From: Junio C Hamano Date: Tue, 14 Feb 2017 19:08:05 GMT Subject: Re: [PATCH v2] remote helpers: avoid blind fall-back to ".git" when setting GIT_DIR Message-ID: In-Reply-To: <20170214061607.qyucfue335aqgji2@sigill.intra.peff.net> Jeff King writes: > On Thu, Dec 29, 2016 at 07:48:45PM -0500, Jeff King wrote: > >> On Thu, Dec 29, 2016 at 04:11:14PM -0800, Jonathan Nieder wrote: >> >> > Thanks. Here's the patch again, now with commit messages and a test. >> > Thanks for the analysis and sorry for the slow turnaround. >> >> Thanks for following up. While working on a similar one recently, I had >> the nagging feeling that there was a case we had found that was still to >> be dealt with, and I think this was it. :) >> >> The patch to the C code looks good. I have a few comments on the tests: > > I happened to run into this problem myself today, so I thought I'd prod > you. I think your patch looks good. Hopefully I didn't scare you off > with my comments. :) Thanks for prodding. I'm tempted to just rip out everything other than the 5-liner fix to transport.c and apply it, expecting that a follow-up patch with updated tests to come sometime not in too distant future.