From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 01 May 2017 00:49:04 GMT
Subject: Re: [PATCH v3 1/9] rebase -i: generate the script via rebase--helper
Message-ID: <xmqqtw55jta7.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <8c1f3519-0768-69d9-4d15-782da0be8390@talktalk.net>

Phillip Wood <phillip.wood@talktalk.net> writes:

> This changes the behaviour of
> git -c rebase.instructionFormat= rebase -i
> The shell version treats the rebase.instructionFormat being unset or set
> to the empty string as equivalent. This version generates a todo list
> with lines like 'pick <abbrev sha1>' rather than 'pick <abbrev sha1>
> <subject>'
>
> I only picked this up because I have a script that does 'git -c
> rebase.instructionFormat= rebase -i' with a custom sequence editor.

Sorry to hear that.  As there is no way to unset a configuration
variable from the command line, "git -c var=" like you did above is
the best we can do, and that why treating unset and empty variable
the same way is often necessary.  It seems that Dscho gave an ack to
your message, so hopefully the final version would not have such a
regression.

Thanks for an early warning.