From: Junio C Hamano Date: Wed, 21 Jun 2017 21:43:45 GMT Subject: Re: [PATCH 04/26] diff.c: introduce emit_diff_symbol Message-ID: In-Reply-To: Stefan Beller writes: >>> I looked through out code base and for enums this is >>> actually strictly enforced, so I guess I have to play >>> by the rules here as I do not want to be the first >>> to deviate from an upheld standard. >> >> You sound like you are trying to find an excuse "not to play by the >> rules". Don't. > > When the rules are not yielding best results, adapting the rules > should be considered. I do not think anybody is saying that it is unreasonable to have a wish that it would be wonderful if we could use C99 features. Trailing comma at the end of enum is the least interesting addition (it is a fix for a previous editions' brown-paper-bag mistake). I'd be delighted if we can drop support for older compilers and start using designated initializers, for example. Finding other's violation of the current coding guideline is *not* the right way to promote for that future, however.