From: Junio C Hamano Date: Fri, 25 Aug 2017 17:45:04 GMT Subject: Re: [RFC 3/7] protocol: tell server that the client understands v2 Message-ID: In-Reply-To: <20170824225328.8174-4-bmwill@google.com> Brandon Williams writes: > + /* If using a new version put that stuff here after a second null byte */ > + strbuf_addch(&request, '\0'); > + strbuf_addf(&request, "version=%d%c", 2, '\0'); > + /* subsequent supported versions can also be added */ > + strbuf_addf(&request, "version=%d%c", 3, '\0'); Isn't this last one meant only as a comment?