From: Junio C Hamano Date: Thu, 15 Mar 2018 20:09:58 GMT Subject: Re: [PATCH v2 2/2] stash push -u: don't create empty stash Message-ID: In-Reply-To: <20180314214642.22185-2-t.gummerer@gmail.com> Thomas Gummerer writes: > no_changes () { > git diff-index --quiet --cached HEAD --ignore-submodules -- "$@" && > git diff-files --quiet --ignore-submodules -- "$@" && > - (test -z "$untracked" || test -z "$(untracked_files)") > + (test -z "$untracked" || test -z "$(untracked_files $@)") Don't you need a pair of double-quotes around that $@?