From: Junio C Hamano <gitster@pobox.com>
Date: Sun, 25 Mar 2018 20:24:52 GMT
Subject: Re: [PATCH v3] filter-branch: fix errors caused by refs that point at non-committish
Message-ID: <xmqqtvt3ewdn.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <5ab7d35a.9060650a.fe7a7.04ef@mx.google.com>

Yuki Kokubun <orga.chem.job@gmail.com> writes:

> References: <xmqqr2o8f7hd.fsf@gitster-ct.c.googlers.com>
> 	<xmqqvadmilx5.fsf@gitster-ct.c.googlers.com>
> 	<5ab46520.0352650a.cc02b.a177@mx.google.com>
> 	<20180323050913.5188-1-orga.chem.job@gmail.com> 
> Content-Type: text/plain
>
>> Grammo (third-person singular 'prints' misspelt without 's'; the
>> "when" clause has a complex subject but no verb).
>> 
>> Perhaps this will salvage what you meant:
>> 
>> 	"git filter-branch -- --all" prints error messages when
>> 	processing refs that point at objects that are not
>> 	committish.
>
> Thanks. I'm gonna fix it.
>
>> Please sign-off your patch (cf. Documentation/SubmittingPatches).
>
> OK I'm gonna add it.
>
> I greatly appreciate for your kind review.
> I couldn't write this patch without your help.
> Thanks.

Heh, it's a team effort, and it is not like I am helping your effort
to build "open source contribution credit" for your coursework ;-)

Thank *you* for contributing to make Git a better system.