From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 18 May 2018 02:16:09 GMT
Subject: Re: [PATCH v2 13/14] merge: use commit-slab in merge remote desc instead of commit->util
Message-ID: <xmqqtvr54sk6.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20180513055208.17952-14-pclouds@gmail.com>

Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:

> diff --git a/commit.c b/commit.c
> index 57049118a5..8202067cd5 100644
> --- a/commit.c
> +++ b/commit.c
> @@ -1574,13 +1574,21 @@ int commit_tree_extended(const char *msg, size_t msg_len,
>  	return result;
>  }
>  
> +define_commit_slab(merge_desc_slab, struct merge_remote_desc *);
> +struct merge_desc_slab merge_desc_slab = COMMIT_SLAB_INIT(1, merge_desc_slab);

s/^/static /; otherwise sparse would complain?