From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 10 Dec 2018 06:42:36 GMT
Subject: Re: [RFC PATCH 1/2] grep: fallback to interpreter if JIT fails with pcre1
Message-ID: <xmqqtvjlkhlv.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20181210004252.GK890086@genre.crustytoothpaste.net>

"brian m. carlson" <sandals@crustytoothpaste.net> writes:

> Considering that some Linux users use PaX kernels with standard
> distributions and that most BSD kernels can be custom-compiled with a
> variety of options enabled or disabled, I think this is something we
> should detect dynamically.
> ...
> My view is that JIT is a nice performance optimization, but it's
> optional. I honestly don't think it should even be exposed through the
> API: if it works, then things are faster, and if it doesn't, then
> they're not. I don't see the value in an option for causing things to be
> broken if someone improves the security of the system.

I agree to both of these two points.  Thanks for a thoughtful
discussion, all.