From: Junio C Hamano Date: Tue, 12 Feb 2019 00:31:00 GMT Subject: Re: [PATCH v3] utf8: handle systems that don't write BOM for UTF-16 Message-ID: In-Reply-To: <20190211235835.GB684736@genre.crustytoothpaste.net> "brian m. carlson" writes: >> - cat lf.utf8.raw | iconv -f UTF-8 -t UTF-${i} >lf.utf${i}.raw && >> - cat crlf.utf8.raw | iconv -f UTF-8 -t UTF-${i} >crlf.utf${i}.raw && >> + cat lf.utf8.raw | eval "write_utf${i}" >lf.utf${i}.raw && >> + cat crlf.utf8.raw | eval "write_utf${i}" >crlf.utf${i}.raw && >> cp crlf.utf${i}.raw eol.utf${i} && >> >> cat >expectIndexLF <<-EOF && > > I'll squash in this fix, thanks. Thanks, all. In the meantime, what I've pushed out has this applied immediately on top. Unless there is anything else, I could squash it in in my next pushout I plan to do tonight, before getting ready to tag -rc1 tomorrow.