From: Junio C Hamano Date: Mon, 13 May 2019 05:05:27 GMT Subject: Re: [PATCH v4 06/11] commit-graph: extract fill_oids_from_packs() Message-ID: In-Reply-To: <30c1b618b139e637122d9476f54d5eb8ce8e0d57.1557411749.git.gitgitgadget@gmail.com> "Derrick Stolee via GitGitGadget" writes: > From: Derrick Stolee > > The write_commit_graph() method is too complex, so we are > extracting methods one by one. > > This extracts fill_oids_from_packs() that reads the given > pack-file list and fills the oid list in the context. > > Signed-off-by: Derrick Stolee > --- Quite straight-forward. Looking good. Thanks.