From: Junio C Hamano Date: Wed, 15 May 2019 02:13:30 GMT Subject: Re: [PATCH] test-lib: try harder to ensure a working jgit Message-ID: In-Reply-To: <20190515011851.GP3654@pobox.com> Todd Zullinger writes: >> This guards against cases where jgit is present on the system, but >> will fail to run, e.g. because of some JRE issue, or missing Java >> dependencies. Seeing if it gets far enough to process the >> "--version" argument isn't perfect, but seems to be good enough in >> practice. It's also consistent with how we detect some other >> dependencies, see e.g. the CURL and UNZIP prerequisites. > > Well said. I indeed avoided putting the detail into the > commit message because it was such a Fedora-specific bug. > I'll update the commit message to add more details though, > borrowing liberally from^W^W^Wperhaps stealing your > suggested wording. > > Thanks! Thanks, all.