From: Junio C Hamano Date: Tue, 21 Jan 2020 21:58:11 GMT Subject: Re: [PATCH v3 2/2] t6025: use helpers to replace test -f Message-ID: In-Reply-To: <20200118083326.9643-7-shouryashukla.oo@gmail.com> Shourya Shukla writes: > Take advantage of helper function 'test_path_is_file()' to > replace 'test -f' since the function makes the code more > readable and gives better error messages. Looks good. Thanks.