From: Junio C Hamano Date: Tue, 13 Oct 2020 19:07:08 GMT Subject: Re: [PATCH] t5500.43: make the check a bit more robust Message-ID: In-Reply-To: <20201013185515.GA2994107@coredump.intra.peff.net> Jeff King writes: >> Work around flakiness in t5500.43 >> >> It seems that this test became flaky only recently, although I have to >> admit that I have no idea why: the involved code does not seem to have >> changed recently at all. It should have been fixed by >> https://lore.kernel.org/git/20200506220741.71021-1-jonathantanmy@google.com/ >> , but apparently wasn't completely fixed, despite what I said in that >> thread. > > I think this is a real bug, and we shouldn't be changing the tests to > accommodate. Users may actually see the broken lines, and our tests are > telling us that. True; I reacted too hastily. Will not queue the workaround ;-)