From: Junio C Hamano Date: Thu, 04 Feb 2021 18:58:29 GMT Subject: Re: [PATCH v4 2/3] range-diff/format-patch: handle commit ranges other than A..B Message-ID: In-Reply-To: <448e6a64fa157990fcc973ce2fe4a9fc2ba1ab32.1612431093.git.gitgitgadget@gmail.com> "Johannes Schindelin via GitGitGadget" writes: > +test_expect_success 'A^! and A^- (unmodified)' ' > + git range-diff --no-color topic^! unmodified^-1 >actual && > + cat >expect <<-EOF && > + 1: $(test_oid t4) = 1: $(test_oid u4) s/12/B/ > + EOF > + test_cmp expect actual > +' Now we actually parse the single-token range, instead of relying on "does it have dot-dot" heuristics, we can make sure that we reject "HEAD^{/^string with .. in it}" as "not a range with negative and positive ends".