From: Junio C Hamano Date: Wed, 21 Apr 2021 18:56:22 GMT Subject: Re: [PATCH v3 01/12] check-non-portable-shell: check for "test -a/-o " Message-ID: In-Reply-To: <87r1j42ffz.fsf@evledraar.gmail.com> Ævar Arnfjörð Bjarmason writes: > Applying your suggestion results in these false positives: > > t4038-diff-combined.sh:135: error: "test A && test B" preferred to "test A -a B": git commit -m "test space change" -a && This is utterly amusing. Consider the suggestion withdrawn.