From: Junio C Hamano Date: Mon, 26 Jul 2021 17:34:26 GMT Subject: Re: [PATCH v3 5/5] [GSOC] ref-filter: add %(rest) atom Message-ID: In-Reply-To: Jacob Keller writes: > On Sat, Jul 24, 2021 at 7:14 AM ZheNing Hu via GitGitGadget > wrote: >> >> From: ZheNing Hu >> >> %(rest) is a atom used for cat-file batch mode, which can split >> the input lines at the first whitespace boundary, all characters >> before that whitespace are considered to be the object name; >> characters after that first run of whitespace (i.e., the "rest" >> of the line) are output in place of the %(rest) atom. >> >> In order to let "cat-file --batch=%(rest)" use the ref-filter >> interface, add %(rest) atom for ref-filter. >> >> Introduce the reject_atom() to reject the atom %(rest) for >> "git for-each-ref", "git branch", "git tag" and "git verify-tag". >> >> Suggected-by: Jacob Keller >> Mentored-by: Christian Couder >> Mentored-by: Hariom Verma >> Signed-off-by: ZheNing Hu >> --- > > Thanks for the improved commit message here. That helps clarify what > this atom does and aids in understanding the implementation. > > Reviewed-by: Jacob Keller Thanks, both.