From: Junio C Hamano Date: Thu, 03 Feb 2022 19:15:51 GMT Subject: Re: [PATCH v2] refs.h: make all flags arguments unsigned Message-ID: In-Reply-To: Han-Wen Nienhuys writes: > On Thu, Feb 3, 2022 at 7:27 PM Junio C Hamano wrote: >> > Yes, enums or not, what I was also pointing out in >> > https://lore.kernel.org/git/220201.86ilty9vq2.gmgdl@evledraar.gmail.com/ >> > is that changing just one logical set of flags at a time would make this >> > much easier to review. >> >> Another thing to consider is how to make this play better with other >> topics in flight. Basing a huge single patch on top of 'seen' is a >> way to ensure that the patch will never be useful. There won't be a >> good time when such a topic can graduate. The topic will also have >> a hard time keeping up with what new topics add while waiting for >> what happen to be in 'seen' today (some of which may even go away >> without graduating) all graduate. >> >> Limiting the scope to small and more stable subset of flags that are >> in 'master' and does not conflict (e.g. no new bit defined to the >> set of flags, no existing bit gets removed, no new callers that use >> the bitset introduced) with other topics would incrementally improve >> the code base, and makes progress in the sense that it reduces the >> remaining work. > > OK. But do we agree we want to use enums? Me and AEvar are in favor, > anyone against? No strong preference either way from me.