From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 23 Sep 2022 17:01:54 GMT
Subject: Re: [PATCH v2] cmd-list.perl: fix identifying man sections
Message-ID: <xmqqtu4yuirh.fsf@gitster.g>
In-Reply-To: <20220923080733.1995862-1-martin.agren@gmail.com>

Martin Ågren <martin.agren@gmail.com> writes:

> We attribute each documentation text file to a man section by finding a
> line in the file that looks like "gitfoo(<digit>)". Commit cc75e556a9
> ("scalar: add to 'git help -a' command list", 2022-09-02) updated this
> logic to look not only for "gitfoo" but also "scalarfoo". In doing so,
> it forgot to account for the fact that after the updated regex has found
> a match, the man section is no longer to be found in `$1` but now lives
> in `$2`.
>
> This makes our git(1) manpage look as follows:
>
>   Main porcelain commands
>        git-add(git)
>            Add file contents to the index.

Thanks.  Will queue.