From: Junio C Hamano Date: Thu, 13 Oct 2022 18:50:06 GMT Subject: Re: About git reporting missing newline for symlinks Message-ID: In-Reply-To: <221013.86k053lkvu.gmgdl@evledraar.gmail.com> Ævar Arnfjörð Bjarmason writes: >>> \ The filename pointed to by the symlink does not end in a newline >> >> While I do not think it would break anybody, I doubt it would give >> us much value. One line above that output is a line that any user, >> who is vaguely familiar with the contents being compared, can >> recognize as giving a pathname, the contents of the symbolic link. > > Clearly it confused the initial reporter upthread :) But to such a user, I highly suspect that the rephased message above still looks like a warning, and will result in the same reaction. IOW, you want to explain why "does not end in a newline" is worth expressing in the output. Saying "does not end in a newline" alone would tell the user what they already know (i.e. the symlink stores the target filename without an extra LF at the end).