From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 30 Jan 2023 19:02:50 GMT
Subject: Re: [PATCH v2 05/10] bundle-uri: download in creationToken order
Message-ID: <xmqqtu073kx1.fsf@gitster.g>
In-Reply-To: <07c4658e-89dd-0f82-77e9-e7c443f747cd@github.com>

Derrick Stolee <derrickstolee@github.com> writes:

> I think there are two possible directions we can have when talking
> about interrupted downloads:
>
> 1. The network connection was disconnected, and the client may want
>    to respond to that with a retry and a ranged request.
>
> 2. The client process itself terminates for some reason, and a
>    second process recognizes that some of the data already exists
>    and could be used for a range request of the remainder.
>
> I think both of these would not be handled at this layer, but
> instead further down, inside fetch_bundle_uri_internal()
> (specifically further down in download_https_uri_to_file()).
>
> Any retry logic should happen there, closer to the connection,
> and at the layer of the current patch, we should assume that any
> retry logic that was attempted ended up failing in the end.
>
> Does that satisfy your concerns here?

Mostly.  We probably do not want / need to cater to "I killed it
with ^C and would want to continue".

Thanks.