From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 09 Jul 2024 16:37:28 GMT
Subject: Re: [PATCH 4/6] transport: add client support for object-info
Message-ID: <xmqqttgyfrnb.fsf@gitster.g>
In-Reply-To: <87ikxfqbm9.fsf@iotcl.com>

Toon claes <toon@iotcl.com> writes:

>> +			temp_ref->old_oid = *(transport->smart_options->object_info_oids->oid + i);
>
> Any reason why you're not using the subscript operator (square brackets)
> like this:
>
> +			temp_ref->old_oid = transport->smart_options->object_info_oids->oid[i];

Much nicer, but fold such overly long lines, please,

			temp_ref->old_oid = transport->smart_options->
				object_info_oids->oid[i];

to make them readable.



> ...
> To be honest, I'm not sure it works, because fetch_object_info() always
> seem to return a non-zero value. I'm not sure this is due to missing
> code coverage, or a bug. I guess it's worth looking into.