From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 12 Nov 2024 09:30:05 GMT
Subject: Re: [PATCH 3/3] refspec: store raw refspecs inside refspec_item
Message-ID: <xmqqttcc4x5u.fsf@gitster.g>
In-Reply-To: <20241112083937.GC3529122@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

> The refspec struct keeps two matched arrays: one for the refspec_item
> structs and one for the original raw refspec strings. The main reason
> for this is that there are other users of refspec_item that do not care
> about the raw strings. But it does make managing the refspec struct
> awkward, as we must keep the two arrays in sync. This has led to bugs in
> the past (both leaks and double-frees).

Yeah, I was wondering about this while reading [2/3], and it is very
satisfying to see that the concluding step for the series ends in
this change.

Thanks.